Skip to content

Use helm templating to hide the HTTPRoute duplication#688

Merged
ensonic merged 1 commit into
mainfrom
ensonic/routes
May 20, 2026
Merged

Use helm templating to hide the HTTPRoute duplication#688
ensonic merged 1 commit into
mainfrom
ensonic/routes

Conversation

@ensonic
Copy link
Copy Markdown
Contributor

@ensonic ensonic commented May 20, 2026 •
edited
Loading

Use a range loop to produce both the traffic and the auth routes in-place. This will avoid having to specify all path matches twice.

$ kubectl get httproute -n app-token-vendor
NAME                      HOSTNAMES                                    AGE
public-key-access         ["www.endpoints.XXX.cloud.goog"]   9d
public-key-access-auth    ["www.endpoints.XXX.cloud.goog"]   6h6m
public-key-manager        ["www.endpoints.XXX.cloud.goog"]   9d
public-key-manager-auth   ["www.endpoints.XXX.cloud.goog"]   6h6m
token-vendor              ["www.endpoints.XXX.cloud.goog"]   9d

@ensonic
Use helm templating to hide the HTTPRoute duplication
e562a21 
Use a range loop to produce both the traffic and the auth routes in-place.
This will avoid having to specify all path matches twice.
@ensonic ensonic requested review from awhdesmond and csieber May 20, 2026 13:43
@ensonic ensonic enabled auto-merge (squash) May 20, 2026 15:45
csieber
csieber approved these changes May 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@csieber csieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea!

@ensonic ensonic merged commit c05dedd into main May 20, 2026
7 checks passed
@ensonic ensonic deleted the ensonic/routes branch May 20, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csieber csieber csieber approved these changes

@awhdesmond awhdesmond Awaiting requested review from awhdesmond

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ensonic @csieber